Re: [exim] [Dovecot] request to have dovecot authenticator d…

Top Page
Delete this message
Reply to this message
Author: Timo Sirainen
Date:  
To: Philip Hazel
CC: exim-users, dovecot
Subject: Re: [exim] [Dovecot] request to have dovecot authenticator driver'officially' included/supported
On Mon, 2006-10-02 at 14:41 +0100, Philip Hazel wrote:
> >    http://www.exim.org/eximwiki/AuthenticatedSmtpUsingDovecot

> >
> > that allows use of Dovecot's native sasl implementation as an
> > authenticator, and that is _seems_ to apply against 4.63 ok, might it
> > be possible to get this integrated into exim core, and have it become
> > 'official'?
>
> I have integrated this patch (it needed a little work - see ChangeLog).
> I have done extremely preliminary testing against Dovecot 1.0_beta8 and
> I think it is OK. The code will be in tonight's snapshot. If anybody who
> is actually running Dovecot would like to do some more serious testing,
> that would be good.


I mentioned this before too, but in case you didn't notice:

int auth_dovecot_server(auth_instance *ablock, uschar *data)
..
       fprintf(f, "VERSION\t%d\t%d\nCPID\t%d\n"
               "AUTH\t%d\t%s\tservice=smtp\trip=%s\tlip=%s\tresp=%s\n",
               VERSION_MAJOR, VERSION_MINOR, getpid(), cuid,
               ablock->public_name, sender_host_address, interface_address,
               data ? (char *) data : "");


Can data parameter contain tab characters? If it can, you should prevent
them from going to dovecot-auth.