Re: [exim] Exim 4.80 RC2 uploaded

Top Page
Delete this message
Reply to this message
Author: Todd Lyons
Date:  
To: exim-dev, exim-users
Subject: Re: [exim] Exim 4.80 RC2 uploaded
Posted in Rich Text so that gmail client wouldn't line-wrap my pastes below.

On Sat, May 19, 2012 at 12:50 AM, Phil Pennock <pdp@???> wrote:
> I have uploaded Exim 4.80 RC2 to:
> Please report issues in reply to this email, on exim-users.


Current master builds just fine on my Ubuntu machines (11.04 and 12.04).
Building RC2 on CentOS 5.x, compiling exim.c is failing with this:

exim.c: In function ‘regex_must_compile’:
exim.c:86: warning: dereferencing type-punned pointer will break
strict-aliasing rules
exim.c: In function ‘usr1_handler’:
exim.c:215: warning: ignoring return value of ‘write’, declared with
attribute warn_unused_result
exim.c: In function ‘show_whats_supported’:
exim.c:1007: warning: implicit declaration of function ‘STRINGIFY’
exim.c:1007: error: expected ‘)’ before string constant
exim.c:1007: warning: format ‘%s’ expects type ‘char *’, but argument 6 has
type ‘int’
exim.c:1007: warning: too few arguments for format
exim.c: In function ‘main’:
exim.c:2417: warning: zero-length printf format string
exim.c:3788: warning: dereferencing type-punned pointer will break
strict-aliasing rules
exim.c:4372: warning: field precision should have type ‘int’, but argument
4 has type ‘long int’
exim.c:3718: warning: ignoring return value of ‘getcwd’, declared with
attribute warn_unused_result
exim.c:3762: warning: ignoring return value of ‘chdir’, declared with
attribute warn_unused_result
exim.c:5243: warning: ignoring return value of ‘chdir’, declared with
attribute warn_unused_result

The relevant lines are:
1007   fprintf(f, "Library version: PCRE: Compile: %d.%d%s\n"
1008              "                       Runtime: %s\n",
1009           PCRE_MAJOR, PCRE_MINOR,
1010           /* PRE_PRERELEASE is either defined and empty or a string.
1011            * unless its an ancient version of PCRE in which case it
1012            * is not defined */
1013 #ifdef PCRE_PRERELEASE
1014 # define STRINGIFY(x) #x
1015           STRINGIFY(PCRE_PRERELEASE) "",
1016 # undef STRINGIFY
1017 #else
1018           "",
1019 #endif
1020           pcre_version());


It looks fine to me, but the #define for some reason is not occurring. Can
you spot anything wrong with this?

...Todd
--
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. -- Martin Golding