Re: [exim] retry rule lost_connection or tls_required

Top Page
Delete this message
Reply to this message
Author: Philip Hazel
Date:  
To: Andre van der Walt
CC: exim-users
Subject: Re: [exim] retry rule lost_connection or tls_required
On Sun, 15 Oct 2006, Andre van der Walt wrote:

> when trying to set a retry rule for lost_connection or tls_required as follows:
> *               tls_required       F,2h,15m; F,1d,4h
> *               lost_connection    F,2h,15m; F,1d,4h

>
> you get the following errors when doing exim -bV
> 2006-10-15 21:38:53 Exim configuration error in line 489 of
> /usr/local/etc/exim/configure:
> unknown or malformed retry error "lost_connection"
> 2006-10-15 21:38:00 Exim configuration error in line 488 of
> /usr/local/etc/exim/configure:
> unknown or malformed retry error "tls_required"


It's amazing that nobody noticed this stupid bug before. The simple
patch that fixes it is below.

Philip

--
Philip Hazel, University of Cambridge Computing Service.




*** exim-4.63/src/readconf.c        Mon Jul 31 15:19:48 2006
--- readconf.c    Tue Oct 17 09:44:13 2006
***************
*** 3454,3463 ****
           strncmpic(q+1, US"failed", p-q-1) == 0)
    *basic_errno = ERRNO_AUTHFAIL;


! else if (strcmpic(pp, US"lost_connection") == 0)
    *basic_errno = ERRNO_SMTPCLOSED;


! else if (strcmpic(pp, US"tls_required") == 0)
    *basic_errno = ERRNO_TLSREQUIRED;


  else if (len != 1 || Ustrncmp(pp, "*", 1) != 0)
--- 3455,3464 ----
           strncmpic(q+1, US"failed", p-q-1) == 0)
    *basic_errno = ERRNO_AUTHFAIL;


! else if (strncmpic(pp, US"lost_connection", p - pp) == 0)
    *basic_errno = ERRNO_SMTPCLOSED;


! else if (strncmpic(pp, US"tls_required", p - pp) == 0)
    *basic_errno = ERRNO_TLSREQUIRED;


else if (len != 1 || Ustrncmp(pp, "*", 1) != 0)