Re: [Exim] ANNOUNCE: exiscan-acl-4.24-13

Top Page
Delete this message
Reply to this message
Author: Oliver Eikemeier
Date:  
To: Tom Kistner
CC: exiscanusers, exim-users
Subject: Re: [Exim] ANNOUNCE: exiscan-acl-4.24-13
Hi Tom,

in the new exiscan-acl-4.24-13, src/malware.c you do:

> /* Routine to check whether a system is big- or litte-endian.
>    Ripped from http://www.faqs.org/faqs/graphics/fileformats-faq/part4/section-7.html
>    Needed for proper kavdaemon implementation. Sigh. */
> #define BIG_ENDIAN      0
> #define LITTLE_ENDIAN   1


which, at least on FreeBSD overwrites the definition from /usr/include/machine/endian.h:

> /*
>  * Definitions for byte order, according to byte significance from low
>  * address to high.
>  */
> #define LITTLE_ENDIAN   1234    /* LSB first: i386, vax */
> #define BIG_ENDIAN      4321    /* MSB first: 68000, ibm, net */
> #define PDP_ENDIAN      3412    /* LSB first in word, MSW first in long */

>
> #define BYTE_ORDER      LITTLE_ENDIAN


You don't include any headers afterwards or use BYTE_ORDER in any other way, so it should
cause no real bug, but just in case...