Re: [pcre-dev] PCRE2 10.35 testing issues on Windows

Top Page
Delete this message
Author: Daniel Richard G.
Date:  
To: Philip Hazel
CC: pcre-dev
Subject: Re: [pcre-dev] PCRE2 10.35 testing issues on Windows
Hi Phillip,

Sorry to have kept you waiting; we had a holiday weekend here in the
U.S. and I have been playing catch-up.

To answer your earlier question: While I fixed the pcre2_test.bat file
(not RunTest.bat) manually to allow my build to proceed, that script is
generated by CMake, so the real fix is to be found in CMakeLists.txt. I
suggested the following edit in my initial e-mail:

diff -ru pcre2-10.35/CMakeLists.txt pcre2-10.35-fixed/CMakeLists.txt
--- pcre2-10.35/CMakeLists.txt 2020-05-09 11:43:10.000000000 -0400
+++ pcre2-10.35-fixed/CMakeLists.txt 2020-11-20 04:37:54.215894941 -0500
@@ -827,7 +827,7 @@
\@echo off
setlocal
SET srcdir=\"${winsrc}\"
-SET pcre2test=\"${winexe}\"
+SET pcre2test=\"${winbin}\\pcre2test.exe\"
if not [%CMAKE_CONFIG_TYPE%]==[] SET pcre2test=\"${winbin}\\%CMAKE_CONFIG_TYPE%\\pcre2test.exe\"
call %srcdir%\\RunTest.Bat
if errorlevel 1 exit /b 1

However, you will want to run this by whoever maintains the CMake support---
and, in particular, added the $<TARGET_FILE:pcre2test> bit that clearly
did not work as intended. I am not familiar with the $<...> syntax
myself, so an alternate fix may better resolve the issue.

As for the PCRE2_HAVE_STDINT problem, I must apologize; on closer
examination, this turned out to be a local edit in my PCRE2 tree for an
as-yet unsubmitted feature. Please disregard this.


Regards,


--Daniel


On Wed, 2020 Dec 2 09:55-05:00, Philip Hazel wrote:
> There is something odd going on. I cannot find the lines you refer to 
> in config-cmake.h.in. Are you sure you have the latest version? A grep 
> of the entire source      pcre2grep -Ir 'STDINT' *   finds no 
> occurrence of PCRE2_HAVE_STDINT. When you say you manually fixed the 
> pcre2_test.bat script, do you really mean RunTest.bat? 
> Regards,   
> Philip

>
>
> On Wed, 25 Nov 2020 at 08:50, Philip Hazel <philip.hazel@???> wrote:
> > Please can you send me a copy of your fixed .bat script so that I'm not guessing what changes to make! (I have no means of testing it.)
> > Regards,
> > Philip
> >


--
Daniel Richard G. || skunk@???
My ASCII-art .sig got a bad case of Times New Roman.