[exim-dev] [Bug 2243] Noise in "exim -bV" stderr with +argum…

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2243] Noise in "exim -bV" stderr with +arguments log_selector
https://bugs.exim.org/show_bug.cgi?id=2243

Phil Pennock <pdp@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pdp@???


--- Comment #1 from Phil Pennock <pdp@???> ---
Hrm, we have a small problem here, with the way that "-bV"/"--version" is
defined in Exim.

Invoking with "-bV" does not mean "print version information and exit". It
just means "print version information, and if not told to anything else, then
that's okay and you can exit success". We don't document that it will exit.

As a result, it's perfectly legitimate to combine "-bV" with other options, to
just have Exim print version information on start-up before doing other things.

"exim -bV -bt postmaster" is perfectly valid, and will do both things.

It's an interesting feature, and one I was unaware of when I made "--version"
simply an alias for "-bV".

That said, I'm can't see why stderr would have been empty before; I can find
one change to the logic since 4.84 was cut, and that is a macro change to make
feature selection more robust:

This guards the entry to all this logic:
-if (((debug_selector & D_any) != 0 || (log_extra_selector & LX_arguments) !=
0)
+if (((debug_selector & D_any) != 0 || LOGGING(arguments))

This guards the actual print:
-  if ((log_extra_selector & LX_arguments) != 0)
+  if (LOGGING(arguments))
     log_write(0, LOG_MAIN, "%s", big_buffer);


I've diffed exim.c from 4.84 against current master, and don't see anything
which would change whether or not the config had even been read by this point.
(There are lots of changes here, but none I see as affecting this).

I see that Debian's "debconf/conf.d/main/90_exim4-config_log_selector" file
uses "+all -subject -arguments" for debugging. Are you 100% sure that you had
+arguments enabled before?

I don't think there's a change on Exim's side here.

--
You are receiving this mail because:
You are on the CC list for the bug.