[pcre-dev] [Bug 1357] Insufficient implementation of PCRE_CA…

Startseite
Nachricht löschen
Autor: Carsten Klein
Datum:  
To: pcre-dev
Betreff: [pcre-dev] [Bug 1357] Insufficient implementation of PCRE_CALL_CONVENTION
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1357

Carsten Klein <cklein05@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #627 is|0                           |1
           obsolete|                            |
 Attachment #628 is|0                           |1
           obsolete|                            |





--- Comment #4 from Carsten Klein <cklein05@???> 2013-05-31 11:26:00 ---
Created an attachment (id=629)
--> (http://bugs.exim.org/attachment.cgi?id=629)
Changes VB6COMPAT final for 8.33

Hi Philip,

finally, I've applied all the changes mentioned above to the sources of the
8.33 release. I have attached all files that need to be changed in a single zip
file.

Also, I decided to remove the calling convention option PCRE_CALL_CONVENTION
from all malloc, free and callout function pointer declarations, except for the
VB6COMPAT case.

Of course, that is still not consistent but, since most C/C++ users will likely
never define anything for PCRE_CALL_CONVENTION, that should not be a major
problem.

However, if you like to honor the defined calling convention throughout the
whole API, you'll always (not only if _MSC_VER or __SYMBIAN__ is defined) need
to wrap the calls to malloc and free with local functions (like LocalPcreMalloc
and LocalPcreFree). These local wrappers then need the PCRE_CALL_CONVENTION
macro, too.

The final zip file contains two files pcre.h.consistent-cc and
pcre_globals.c.consistent-cc which contain an implementation with the calling
convention applied consistently for both the VB6COMPAT case and the default
C/C++ case. It is up to you to decide, which implementation will be used for
PCRE.

Still nothing has been done for the VPCOMPAT case (Virtual Pascal) since I did
not find any implementation for it.

Carsten


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email