Author: Micha Lenk Date: To: exim-dev Subject: Re: [exim-dev] Quoting of percent and underscore pgsql_quote()
Hi Phil,
On 09/27/2012 04:32 AM CEST +02:00, Phil Pennock wrote: >> So, given that the Perl module DBD::Pg dropped the escaping of these
>> > characters already some years ago (CPAN RT #27538), what are the reasons
>> > to keep this useless escaping of percent and underscore in future Exim code?
> Confirmation that the relevant code change is adequate. :)
>
> So, src/lookups/pgsql.c in function pgsql_quote(), around line 463, you
> should find:
>
> else if (Ustrchr("\n\t\r\b\"\\%_", c) != NULL)
>
> If you remove the % and _ from that string, does that fix the problem
> for you?
>
> By my reading of the code, that's all that's required.
I second that, but also only by reading the code. Once I have time to
actually work on that again, I will try it out and report back my results.
