Re: [exim-dev] Possible runtest fix?

Góra strony
Delete this message
Reply to this message
Autor: Todd Lyons
Data:  
Dla: exim-dev
Temat: Re: [exim-dev] Possible runtest fix?
On Tue, May 22, 2012 at 5:00 PM, Phil Pennock <pdp@???> wrote:
> On 2012-05-22 at 09:05 -0700, Todd Lyons wrote:
>> I have Ubuntu and it uses a version of 'ls' that causes test 345 to
>> fail.  Is the following addition to runtest too hackish or is it ok to
>> commit?
> Does setting LC_ALL=C in the environment before invoking runtest fix
> things?


Yes.

> I wonder if runtest should simply do:
>  $ENV{'LC_ALL'} = 'C';
> at startup?


Applied locally to my runtest script, tested, and confirmed it fixes
test 345, so I ran tests 1 - 565. Now test 345 passes, and only the
same 4 tests as normal fail (152, 358, 373, and 548). I can find no
tests that this causes a failure in.

That was a great catch, Phil. You can see it quite plainly:

[exim-build@tlyons ~/projects/exim/test (master)]$ vdir test-mail/exim-build
-rw------- 1 exim-build exim-build 0 2012-05-23 06:30 test-mail/exim-build
[exim-build@tlyons ~/projects/exim/test (master)]$ LC_ALL=C vdir
test-mail/exim-build
-rw------- 1 exim-build exim-build 0 May 23 06:30 test-mail/exim-build

I'll commit and push.

...Todd

--
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. -- Martin Golding