Re: [exim-dev] [Bug 1184] code refactoring in acl.c

Top Page

Reply to this message
Author: Todd Lyons
Date:  
CC: exim-dev
Subject: Re: [exim-dev] [Bug 1184] code refactoring in acl.c
On Mon, Mar 19, 2012 at 3:19 PM, Phil Pennock <pdp@???> wrote:

> Have you tried running the test suite to look for regressions?


I have experienced little success trying to run the test suite. I
have an nfs mounted home directory with root squash, so I copy it to
the local harddrive. In order to run the test suite, I had to create
a second user, not my login name. That seems to be the basic
requirements (and manually adding /sbin:/usr/sbin to the path).

But then I get slight errors on each test. This is typical output:

Basic/0004 Caseful address blocking
===============f test-stdout-munged with stdout/0004 failed
Line 6 of "test-stdout-munged" does not match line 6 of "stdout/0004".
----------
220 the.local.host.name ESMTP Exim 4.77_1102-226c389 Tue, 2 Mar 1999
09:44:33 +0000
----------
220 the.local.host.name ESMTP Exim x.yz Tue, 2 Mar 1999 09:44:33 +0000
===============
1 difference found.
"test-stdout-munged" contains 114 lines; "stdout/0004" contains 114 lines.

So is it safe to say that the test suite should only be run on
official releases and not arbitrary points on the git tree? Or should
I be calling runtest with the update command to update the test status
files? That seems like it kinda defeats the point of tests :-/

...Todd
--
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. -- Martin Golding