Re: [exim-dev] Refactor optional MAIL args processing

Top Page

Reply to this message
Author: Phil Pennock
Date:  
To: Todd Lyons
CC: exim-dev, Jeremy Harris
Subject: Re: [exim-dev] Refactor optional MAIL args processing
On 2012-03-29 at 12:11 -0700, Todd Lyons wrote:
> 1) Is it conforming to exim standards?


We have standards? Why does nobody tell me these things?

More seriously: there are several different code styles in the project;
just try to persist the style of the file you're touching.

> 2) Does it result in sane looking code?


I'm almost asleep and haven't applied the patch, but what I get mentally
from reading the diff looks somewhat sane.

> Comments and feedback are welcome.


I'm glad to see this happening. :)