[exim-dev] [Bug 1225] New: testsuite fails for ratelimit

Top Page

Reply to this message
Author: Jeremy Harris
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 1225] New: testsuite fails for ratelimit
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1225
           Summary: testsuite fails for ratelimit
           Product: Exim
           Version: 4.77
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Test harness
        AssignedTo: nigel@???
        ReportedBy: jgh146exb@???
                CC: exim-dev@???, jgh146exb@???



0038 - I suspect the ratelimit debug output has been enhanced,
and wasn't the calculation changed to give 1 rather than 0 for a first offence?

Lines 14-20 of "test-stderr-munged" do not match lines 14-19 of "stderr/0038".
----------
>>> ratelimit condition count=1 0.0/1h/per_mail/V4NET.9.8.7
>>> ratelimit creating new rate data block
>>> ratelimit initializing new key's rate data
>>> ratelimit db updated
>>> ratelimit computed rate 1.0
>>> warn: condition test succeeded

LOG: H=(test.ex) [V4NET.9.8.7] Warning: RCPT: sender_rate=1.0
sender_rate_limit=0 sender_rate_period=1h
----------
>>> ratelimit condition limit=0 period=3600 key=1h/per_mail/strict/V4NET.9.8.7
>>> ratelimit initializing new key's data
>>> ratelimit db updated
>>> ratelimit computed rate 0.0
>>> warn: condition test succeeded

LOG: H=(test.ex) [V4NET.9.8.7] Warning: RCPT: sender_rate=0.0
sender_rate_limit=0 sender_rate_period=1h
===============

however, I'm concerned about the last item noted for 0038:
Lines 234-240 of "test-stderr-munged" do not match lines 230-235 of
"stderr/0038".
----------
>>> ratelimit condition count=19 0.0/1h/per_mail/V4NET.9.8.6
>>> ratelimit creating new rate data block
>>> ratelimit initializing new key's rate data
>>> ratelimit db updated
>>> ratelimit computed rate 19.0
>>> warn: condition test succeeded

LOG: 10HmbC-0005vi-00 H=(test.ex) [V4NET.9.8.6] Warning: DATA: sender_rate=19.0
sender_rate_limit=0 sender_rate_period=1h
----------
>>> ratelimit condition limit=0 period=3600 key=1h/per_byte/strict/V4NET.9.8.6
>>> ratelimit initializing new key's data
>>> ratelimit db updated
>>> ratelimit computed rate 0.0
>>> warn: condition test succeeded

LOG: 10HmbC-0005vi-00 H=(test.ex) [V4NET.9.8.6] Warning: DATA: sender_rate=0.0
sender_rate_limit=0 sender_rate_period=1h
===============
.... given that the computed rate is so different.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email