------- You are receiving this mail because: -------
You are the QA contact for the bug.
http://bugs.exim.org/show_bug.cgi?id=139
--- Comment #20 from Tony Finch <dot@???> 2008-05-14 14:57:21 ---
Some comments based on a fairly cursory read-through of the patch...
I'm not sure that configuring the available lookups by installing files in
a library directory is very nice. I can see it makes sense from a Linux
distribution point of view, but when building from source or creating a
unified package it makes sense to install all the lookups then load only
the necessary ones at run time. I'm not sure if this would lead to a
chicken/egg problem.
drtables.c:
The #include <dlfcn.h> should be removed for portability to
systems without that header. Instead add defined(LOOKUP_MODULE_DIR) to
the #if on line 463 of exim.h which guards another #include <dlfcn.h>.
lookupapi.h:
This file is missing the copyright and end-of-file rubric. The LMM1
comment should be less cryptic.
lookups/Makefile:
This file is gmake-only which is a nasty regression. Exim's build system
has stuff in the scripts directory that constructs the actual Makefile
based on EDITME. I would greatly prefer it if that mechanism were adapted
to support the new functionality so that we don't have to add another
build dependency.
The .c.so rule is non-portable. The shared-library command line options
need to be made into an EDITME option.
Tony.
--
Configure bugmail:
http://bugs.exim.org/userprefs.cgi?tab=email
