------- You are receiving this mail because: -------
You are on the CC list for the bug.
http://bugs.exim.org/show_bug.cgi?id=632
--- Comment #6 from Sean Middleditch <elanthis@???> 2007-11-20 19:31:58 ---
(In reply to comment #5)
> I wonder if and/or how much these changes will affect performance? Hard
> to say until one has tried it, I suppose.
I don't think it'll be much of a hit. Granted, avoiding the one extra copy in
my target use case probably isn't going to make a huge impact, either.
To be honest, I'm more worried about code complexity. If all these extra
pointer checks make the code significanly uglier, I don't think it'll be worth
merging a patch to add them. The one extra copy is something I'd like to
avoid, but not if it'll make your maintenance work a lot harder.
> > Most of the functions just need to take a copy of the end pointer.
>
> The *internal* functions should not need this if they have the "cd"
> (compile data) variable passed to them, because cd->pattern_end has the
> required value.
Ah, alright. I only managed to get to a couple of functions so far - still
getting used to the codebase.
--
Configure bugmail:
http://bugs.exim.org/userprefs.cgi?tab=email
