[exim-dev] [Bug 245] Ability to add to OK message for SMTP c…

Top Page
Delete this message
Reply to this message
Author: World Wide Web Owner
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 245] Ability to add to OK message for SMTP commands
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

http://www.exim.org/bugzilla/show_bug.cgi?id=245





------- Comment #9 from anomie@???  2006-11-15 20:06 -------
One problem (that was in my original patch, oops!) in the HELO response. With
this ACL:
  acl_check_helo:
    accept message = 220 $primary_hostname etc.


We get this transaction:
220 mail.example.com ESMTP Exim 4.64 Wed, 15 Nov 2006 14:27:31 -0500
EHLO client.example.com
220- mail.example.com etc.
220-SIZE 67108864
220 HELP
QUIT
221 mail.protech1inc.com closing connection

Note the extra space in the first line of the HELO response. It seems simple
enough to fix, though (at smtp_in.c line 2682):
if (smtp_code[codelen-1] == ' ') codelen--;
Or you could do something more along the lines of smtp_respond, or you could
just drop everything except the first 3 characters of smtp_code since RFC 2034
doesn't call for extended status codes on the EHLO response anyway.

The 'connect' response seems to handle it correctly, as does smtp_respond.
Everything else seems to use smtp_respond, so everything else should be ok as
far as this goes.

--
Configure bugmail: http://www.exim.org/bugzilla/userprefs.cgi?tab=email