Re: [exim-dev] [PATCH] Allow a message to be set from accept…

Top Page
Delete this message
Reply to this message
Author: Simon Arlott
Date:  
To: exim-dev
Subject: Re: [exim-dev] [PATCH] Allow a message to be set from accept in DATA ACL
On 24/07/06 14:29, Philip Hazel wrote:
> I haven't looked in detail at the code, but isn't there an ambiguity?
> If you have
>
>    accept  message = something
>            endpass 
>            <some conditions here>

>
> the message is used as an error message when the result is "deny". So
> how can it also be used when the result is "accept"? Or are you thinking
> of
>
>    accept  message = error message
>            endpass
>            <some conditions here>
>            message = an accept message

>
> ? If so that feels kind of awkward because the explanation of where
> "message" has to go gets complicated. Also, more seriously, if you
> don't have the second message, won't the first message get used in
> error? In which case a lot of existing configurations will break.
>


I hadn't considered endpass at all, it seems like a different condition name would be better to set the reply used such as "response = ", although then it has to get passed around like the other message types too:

require acl = an_acl
accept

an_acl:
accept message = accept message

--
Simon Arlott