[exim-dev] [Bug 3067] New: eximon can't handle new message i…

https://bugs.exim.org/show_bug.cgi?id=3067

            Bug ID: 3067
           Summary: eximon can't handle new message identification format
           Product: Exim
           Version: 4.97
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Eximon
          Assignee: unallocated@???
          Reporter: exim@???
                CC: exim-dev@???

eximon can't handle new message identification format. The queue view truncates
the internal message id to 16 chars and starting actions via menue does not
work because command arguments are truncated to.

I'm not sure I found all the affected areas, but the following resolved the
issues I know of:

diff --git a/src/exim_monitor/em_hdr.h b/src/exim_monitor/em_hdr.h
index feffa6bfc..f79686a80 100644
--- a/src/exim_monitor/em_hdr.h
+++ b/src/exim_monitor/em_hdr.h
@@ -190,7 +190,7 @@ typedef struct queue_item {
int update_time;
int size;
uschar *sender;
- uschar name[17];
+ uschar name[MESSAGE_ID_LENGTH + 1];
uschar seen;
uschar frozen;
uschar dir_char;
diff --git a/src/exim_monitor/em_log.c b/src/exim_monitor/em_log.c
index 55925d786..46797c864 100644
--- a/src/exim_monitor/em_log.c
+++ b/src/exim_monitor/em_log.c
@@ -108,7 +108,7 @@ length = Ustrlen(buffer);
#ifdef ANONYMIZE
{
uschar *p = buffer + 9;
- if (p[6] == '-' && p[13] == '-') p += 17;
+ if (p[MESSAGE_ID_TIME_LEN] == '-' && p[MESSAGE_ID_TIME_LEN +
MESSAGE_ID_PID_LEN + 1] == '-') p += MESSAGE_ID_LENGTH + 1;

   while (p < buffer + length)
     {

Messages with IDs in the old format that may still be in the spool are not
included in this patch.

BTW: src/exinext.src line 166 also cannot handle the new format. But because
exinext is as broken as it is, this actually has no effect. Line 166 is
obsolete because of line 181.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@???
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/