[exim-dev] [Bug 2916] dsearch erroneously requires read perm…

Pàgina inicial
Delete this message
Reply to this message
Autor: admin
Data:  
A: exim-dev
Assumpte: [exim-dev] [Bug 2916] dsearch erroneously requires read permission
https://bugs.exim.org/show_bug.cgi?id=2916

--- Comment #5 from Martin Kealey <from-exim-bugzilla@???> ---
Thanks for taking the extra time to make a detailed review my patch. I will
make the changes you have requested and upload a new patch file soon.

Overall I wanted to achieve three things:
1. fix the "directory read permission" problem.
2. enable a check for S_ISLNK (filter=symlink) and S_ISFIFO (filter=fifo or
filter=pipe), and allow it to be daisy-chained so that one can also check the
target of the link.
3. check for the existence of a sentinel but then exclude it (ret=dir).

When I started on this second point, I realised that each additional supported
inode type would need a separate S_ISxxx test, when in fact only one of them
could possibly match, so it seemed reasonable to first convert this to a small
bitmap that could be checked using a bitwise-and operation. (Having done that,
it was trivial to include all the other standard S_IFxxx inode types, and they
could be accommodated without runtime overhead.)

--
You are receiving this mail because:
You are on the CC list for the bug.