https://bugs.exim.org/show_bug.cgi?id=2916
Jeremy Harris <jgh146exb@???> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #4 from Jeremy Harris <jgh146exb@???> ---
Sigh. Half the point of splitting it up was to make my review simpler.
That said:
- Only put new features in NewStuff, and only put changes in ChangeLog.
- cdev not documented (mind, what's the utility of bdev, cdev?)
- I'll need convincing on the utility of the "nodots" filter
- Ditto the shortcut combo modes
- What range of platforms has been tested for the USE_AT_FILE ifdeffery?
- Declare variables at start of block, not interspersed with
code (except initialisers)
- Use project memory allocation facilities, not direct "malloc()".
(Mail me to discuss; it's not immediately obvious)
- Project-standard block comment style!
- That UNUSED macro is fugly. Is there any way to have it *not* in the
function definition?
- "%#x" doesn't work
- S_IFMT_from_index - arg used more than once. Rewrite as inlineable fn
(see, eg, functions.h)
--
You are receiving this mail because:
You are on the CC list for the bug.
