On 26/04/2022 08:28, Andrew C Aitchison via Exim-dev wrote:
>> • Jeremy Harris via Exim-announce [2022-04-23 20:23]:
>>> Notable removals since 4.95:
>>>
>>> - the "allow_insecure_tainted_data" main config option and the
>>> "taint" log_selector. These were previously deprecated.
>
> That isn't a good combination. Please could we keep the option to
> allow_insecure_tainted_data if there are new taint features ?
>
> That way we can continue to run live systems while we resolve
> these sort of problems.
The trouble with that is that it means the coverage of tracking
tainted data use can never be extended.
The commit for that removal is fairly extensive:
$ git log --stat 8f2cf8f5ad^1..8f2cf8f5ad
commit 8f2cf8f5adaa08ef84b47bf9bc2f71e39236c22d
Author: Jeremy Harris <jgh146exb@???>
Date: Tue Mar 1 23:12:53 2022 +0000
Revert introduction of alloc_insecure_tainted_data
tidy log.c
(cherry picked from commit 0327b6460eec64da6b0c1543c7e9b3d0f8cb9294)
(cherry picked from commit 8021b95c2e266861aba29c97b4bb90dc6f7637a2)
This reverts commit f9a3fcddba223133019368e7cd6d51449fc54e7b.
This reverts commit 8fc13e4adcdf5d0cec382c401ce72592569084fe.
This reverts commit 2382cd3e81838709abd3b0c1b410f65274d90e25.
This reverts commit ace68726852d08deec815a37f369a4e31be77813.
This reverts commit 4a2bd5dc2f157c50b7e4e7491eac1c930efd2100.
This reverts commit e8b8b133c685e7b09f672016d117c7d8b49e70b1.
This reverts commit f7509ba6fb5e1033c1406b87f057c9c48a217d27.
This reverts commit dbac5a049acbe645a816b4a5e895c5be0de53483.
This reverts commit f7da81e789e2f20b00f46f07260488f337984b84.
This reverts commit f7c791b769a3a5395d92d29d27aa58f9d442373c.
This reverts commit 0fa46a83a55054c65ffc539405f62bf86aac5b44.
This reverts commit ec7e44dc9134307d74afa4b07f09afbdd019282c.
This reverts commit ee4924bc711f54a751448fb5cee5ec4fc9c96196.
This reverts commit 951b668a191ef510a4e27d8204c5fa82ca957a07.
This reverts commit 18d243312bf3a23bd0f464fac44797e2720e03ec.
This reverts commit 16c884a4818594069253de460bf9926f69d50fe5.
This reverts commit 368ecb000c58995c5f61443d45d43942f1f431d0.
This reverts commit 331817e995b05793ec840476fac67e8f7c638a47.
This reverts commit 07343a5b1968f4f5e41664c15fd636bdb6a6cc48.
This reverts commit 060cf1e3c9a0a6960b771cdff6f0a5a2ca9b114c.
This reverts commit 28d2eab1414ef8d20ff0fde7026aa52fd01ef795.
This reverts commit b6b4b129892a99747a586e5d4acb68fe7176ab4b.
This reverts commit 77b478579a0029def01d1b3a4ea591eac447832a.
This reverts commit 0103b34645278151851c31cf1c1976150d907bb4.
This reverts commit f94ca3e3ed2bc5a68ac54c5487e0216ea8db8470.
This reverts commit 7a33a3fc2c1ae4df30eaabaf25fc59e2d6ab5d6c.
This reverts commit 305c0579ab4286b464c2cd589843a7e60f59dfaf.
doc/doc-docbook/spec.xfpt | 28 ------------
doc/doc-txt/ChangeLog | 3 ++
src/src/EDITME | 7 ---
src/src/acl.c | 38 +++++++----------
src/src/config.h.defaults | 2 -
src/src/dbstuff.h | 6 ++-
src/src/deliver.c | 16 +++----
src/src/directory.c | 4 +-
src/src/expand.c | 212 +++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------
src/src/functions.h | 54 ++++++-----------------
src/src/globals.c | 10 -----
src/src/globals.h | 4 --
src/src/log.c | 130 +++++++++++++++++++++++---------------------------------
src/src/lookups/lf_sqlperform.c | 14 +++---
src/src/macros.h | 3 --
src/src/parse.c | 6 ++-
src/src/rda.c | 4 +-
src/src/readconf.c | 3 --
src/src/routers/rf_get_transport.c | 4 +-
src/src/search.c | 8 +++-
src/src/smtp_out.c | 7 ++-
src/src/transports/appendfile.c | 11 -----
src/src/transports/autoreply.c | 21 ++++-----
src/src/transports/pipe.c | 9 ++--
src/src/transports/smtp.c | 5 ++-
test/aux-fixed/0990/example.com | 1 -
test/confs/0990 | 2 -
test/log/0608 | 2 +-
test/paniclog/0608 | 2 +-
test/scripts/0990-Allow-Tainted-Data/0990 | 7 ---
test/scripts/0990-Allow-Tainted-Data/REQUIRES | 1 -
test/stderr/0608 | 2 +-
test/stderr/0990 | 3 --
test/stderr/2620 | 24 +++++------
test/stdout/0990 | 4 --
35 files changed, 259 insertions(+), 398 deletions(-)
- and probably cannot be directly reverted, since the support
for taint-tracking was complexified to handle lookup-quote
tracking (4191cb1503).
--
Cheers,
Jeremy
