I spent an amount of time trying to get latest DMARC work against master EXIM, over last few weeks. It was only one method DMARC has refactored, with extra parameter, and EXIM integration isn’t it taking into account.
I found this bug issue opened on
https://github.com/trusteddomainproject/OpenDMARC/issues/167 <
https://github.com/trusteddomainproject/OpenDMARC/issues/167>
Also this bug report, its claiming to resolve it yet not sure why EXIM still breaking when compiling against 1.4, refer to
https://bugs.exim.org/show_bug.cgi?id=2728 <
https://bugs.exim.org/show_bug.cgi?id=2728>
Note as per EXIM configuration file documentation, DMARC 1.3.2, at
https://github.com/trusteddomainproject/OpenDMARC/tree/rel-opendmarc-1-3-2 <
https://github.com/trusteddomainproject/OpenDMARC/tree/rel-opendmarc-1-3-2>, works perfectly fine yet, when I compile EXIM against 1.4, I get “ few argument passed to function “ failure in opendmarc_policy_store_dkim function, that is referenced in following files,
https://github.com/trusteddomainproject/OpenDMARC/blob/2aafb015a56d40e8a1949dc6d2ab0057aaf8b32f/libopendmarc/dmarc.h <
https://github.com/trusteddomainproject/OpenDMARC/blob/2aafb015a56d40e8a1949dc6d2ab0057aaf8b32f/libopendmarc/dmarc.h>
https://github.com/trusteddomainproject/OpenDMARC/blob/2aafb015a56d40e8a1949dc6d2ab0057aaf8b32f/libopendmarc/opendmarc_policy.c <
https://github.com/trusteddomainproject/OpenDMARC/blob/2aafb015a56d40e8a1949dc6d2ab0057aaf8b32f/libopendmarc/opendmarc_policy.c>
https://github.com/trusteddomainproject/OpenDMARC/blob/7c1503119854da500a35ec74b5153e83d222cc0e/opendmarc/opendmarc.c
The changes that is breaking its in this commit
https://github.com/trusteddomainproject/OpenDMARC/commit/dbd87868f2ca9c2ef11529cd757d1cc5ab228833#diff-e2a20f3fdec887360a43680caeaa8f7b69fa376bd05371b4fe866204ff2f061d
EXIM, references to opendmarc_policy_store_dkim function it should integrate the handling for the new argument of “ u_char *selector. "
I would very much appreciate if someone is fully understanding how DMARC works, would integrate a fix, certainly with thanks.
Zakaria.
> On 9 Jan 2022, at 11:44, Jeremy Harris via Exim-users <exim-users@???> wrote:
>
> On 08/01/2022 18:30, Edwin Balani via Exim-users wrote:
>> Can't you rely on OPENDMARC_LIB_VERSION? It's defined in dmarc.h:
>
> Quite possibly. Now, is the changed API documented? Or are we
> supposed to inspect the libdmarc code and watch for API-breaking
> changes, evermore? And *guess* from the variable names used
> what the new semantics might be? Or read deeply enough into the
> libdmarc implementation to verify the changed behaviour?
>
> Who will put this effort in?
>
> What about exim regression testsuite support for dmarc, something
> we currently don't have? And the maintenance of that, and the the
> ongoing monitoring of testsuite runs and fixing of things found?
>
> Volunteers? I'm expecting a deathly hush, as usual.
>
> --
> Cheers,
> Jeremy
>
> --
> ## List details at https://lists.exim.org/mailman/listinfo/exim-users
> ## Exim details at http://www.exim.org/
> ## Please use the Wiki with this list - http://wiki.exim.org/
