[exim-dev] [Bug 2817] readconf authenticator confusion

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2817] readconf authenticator confusion
https://bugs.exim.org/show_bug.cgi?id=2817

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???


--- Comment #2 from Git Commit <git@???> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/9eca4f4b6902ff84b90d9bec9605896394f3d690

commit 9eca4f4b6902ff84b90d9bec9605896394f3d690
Author:     Wolfgang Breyha <wbreyha@???>
AuthorDate: Sun Oct 24 12:46:29 2021 +0100
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Sun Oct 24 12:46:29 2021 +0100


    Fix error message for multiple authenticators misconfiguration.  Bug 2817
---
 src/src/readconf.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)


diff --git a/src/src/readconf.c b/src/src/readconf.c
index 754ab19..907ffeb 100644
--- a/src/src/readconf.c
+++ b/src/src/readconf.c
@@ -4190,11 +4190,12 @@ for (auth_instance * au = auths; au; au = au->next)

   for (auth_instance * bu = au->next; bu; bu = bu->next)
     if (strcmpic(au->public_name, bu->public_name) == 0)
-      if ((au->client && bu->client) || (au->server && bu->server))
+      if (  au->client && bu->client
+     || au->server && bu->server)
         log_write(0, LOG_PANIC_DIE|LOG_CONFIG, "two %s authenticators "
           "(%s and %s) have the same public name (%s)",
-          au->client ? US"client" : US"server", au->name, bu->name,
-          au->public_name);
+          au->client && bu->client ? US"client" : US"server",
+      au->name, bu->name, au->public_name);
 #ifndef DISABLE_PIPE_CONNECT
   nauths++;
 #endif


--
You are receiving this mail because:
You are on the CC list for the bug.