[pcre-dev] [Bug 2794] pcre2grep directory recursion has trou…

Pàgina inicial
Delete this message
Autor: admin
Data:  
A: pcre-dev
Assumpte: [pcre-dev] [Bug 2794] pcre2grep directory recursion has trouble with certain symlinks on macOS
https://bugs.exim.org/show_bug.cgi?id=2794

--- Comment #3 from Thomas Tempelmann <tempelmann@???> ---
I checked what "grep" does with this recursion. Turns out that it explicitly
detects it:

grep: warning: /Applications/iTunes &
iPod/Senuti.app/Contents/Frameworks/CrashReporter.framework/Resources/Crash
Reporter.app/Contents/Frameworks/CrashReporter.framework/Resources/Crash
Reporter.app: recursive directory loop

So, I guess other tools are prepared for this, just not pcre2grep, yet.

And if you look at grep's source code, you'll find that it, indeed, uses
fts_open to handle this:

https://opensource.apple.com/source/text_cmds/text_cmds-99/grep/util.c.auto.html

Handling this would cause a major rewrite of the current code, but using
fts_open would probably also simplify it, handle this symlink recursion
properly, and may even speed up the parsing – I use fts myself in my Find Any
File app and found that it performs best, see also my blog on this topic:

https://blog.tempel.org/2019/04/dir-read-performance.html

Cheers!

--
You are receiving this mail because:
You are on the CC list for the bug.