[pcre-dev] [Bug 2769] r1315: apple_update_wx_flags() calls …

Kezdőlap
Üzenet törlése
Szerző: admin
Dátum:  
Címzett: pcre-dev
Régi témák: [pcre-dev] [Bug 2769] New: r1315: apple_update_wx_flags() calls unavailable API when compiling to deploy on older macOS
Tárgy: [pcre-dev] [Bug 2769] r1315: apple_update_wx_flags() calls unavailable API when compiling to deploy on older macOS
https://bugs.exim.org/show_bug.cgi?id=2769

--- Comment #10 from Thomas Tempelmann <tempelmann@???> ---
> 1) your library will segfault if it ever runs in a version older than
> arm64/11


Macs with ARM do not run any macOS version before 11, so this is moot.

> 2) you need to check at runtime EVERY time if you are running in 11 or
> newer, which is silly because that is all you will ever run on (unless you
> have access to a non public version of the OS)


The runtime check is very fast, and it'll only be done when I compile a regex
for JIT. Besides, It's understood that compiling a regex takes time, whereas
then performing the search through the JIT compiled code is fast, and
presumably doesn't even run into this check then, right? So, I see absolutely
no problem here.

There is no way around this runtime check IF one wants to support older macOS
versions.

The only thing you could do is to remove the runtime check IF the code is built
for a minimum of macOS 11. But since this runtime check does not cost any
measurable performance, this is overkill.

Fact is that the current solution is not useable for anyone wanting to support
any older macOS versions. That's much worse than adding this check.

--
You are receiving this mail because:
You are on the CC list for the bug.