Re: [exim] Testing 4.95-RC0 questions and warnings

Top Pagina
Delete this message
Reply to this message
Auteur: Thomas Noll
Datum:  
Aan: exim-users
Onderwerp: Re: [exim] Testing 4.95-RC0 questions and warnings
Am Montag, 19. Juli 2021, 16:05:39 CEST schrieb Jeremy Harris via Exim-users:

> Yup, known, and only appeared there as a result of pushing constification
> further through the code. The data items should be readonly, and that
> has always been the case.


But here
filter.c:2042:12: warning: assignment discards 'const' qualifier from pointer
target type [-Wdiscarded-qualifiers]

---
fmsg = expargs[0];                /*XXX loses track of const */
      if (Ustrlen(fmsg) > 1024) Ustrcpy(fmsg + 1000, US" ... (truncated)");
      fmsg = US string_printing(fmsg);
----


a const value is modified. One could copy the value, but at first sight i'd
rather drop the const here.

> Volunteers welcome (as I keep saying).


Tempting. But i dislike diffs caused by formatting, and i dislike
manual formatting. So do you have a common formatting tool/config?

Best regards
Thomas