[exim-dev] [Bug 2733] log_file_path=syslog null-pointer dere…

トップ ページ
このメッセージを削除
このメッセージに返信
著者: admin
日付:  
To: exim-dev
古いトピック: [exim-dev] [Bug 2733] New: log_file_path=syslog null-pointeer dereference breakage on local delivery with allow_insecure_taint_data patch
題目: [exim-dev] [Bug 2733] log_file_path=syslog null-pointer dereference breakage on local delivery with allow_insecure_taint_data patch
https://bugs.exim.org/show_bug.cgi?id=2733

--- Comment #12 from Andreas Metzler <eximusers@???> ---
(In reply to Andreas Metzler from comment #10)
[...]
> ... so my log.c is identical what you get by
> a) checking out 4.94.2+fixes
> b) git merge exim-4.94.2+taintwarn
> c) patch -p1 < /tmp/patch2.patch


I think I can see what goes wrong in the patched log.c:

724 set_file_path(BOOL *multiple) ()
[...]
728 const uschar *ss = *log_file_path ? log_file_path : US LOG_FILE_PATH;
729
730  if (*ss)
731    for (logging_mode = 0;
732        s = string_nextinlist(&ss, &sep, log_buffer, LOG_BUFFER_SIZE); )
733     {
[...]
Empty element:
748        else if (*log_file_path && LOG_FILE_PATH[0])
749      {
750      ss = US LOG_FILE_PATH;
751      continue;
752      }


So when the function looks at ":syslog" an empty element is found. The
log_file_path is ignored and the LOG_FILE_PATH compile time setting is parsed
*instead*, ignoring any further settings ("syslog") in log_file_path.

--
You are receiving this mail because:
You are on the CC list for the bug.