Re: [exim] "allow_insecure_tainted_data = yes" - was: tainte…

Αρχική Σελίδα
Delete this message
Reply to this message
Συντάκτης: Heiko Schlittermann
Ημερομηνία:  
Προς: exim-users
Υ/ο: Andreas Metzler
Αντικείμενο: Re: [exim] "allow_insecure_tainted_data = yes" - was: tainted data issues
Thank you for spending your time :)

Andreas Metzler via Exim-users <exim-users@???> (So 25 Apr 2021 08:12:58 CEST):
> void
> -openlogs();
> +open_logs(const char *m);
> is the proper fix?


It is one possible fix. But the char* isn't used anymore (was there for
debugging). I updated the branch.

> log.c: In function 'set_file_path':
> log.c:654:45: warning: pointer type mismatch in conditional expression
> 654 | uschar *ss = *log_file_path ? log_file_path : LOG_FILE_PATH;


Same here. Fixed.

> In file included from exim.h:486,
>                  from log.c:13:
> log.c:657:31: warning: passing argument 1 of 'string_nextinlist_trc' from incompatible pointer type [-Wincompatible-pointer-types]
>   657 | while ((s = string_nextinlist(&ss, &sep, log_buffer, LOG_BUFFER_SIZE)))
> functions.h:560:25: note: in definition of macro 'string_nextinlist'
>   560 |  string_nextinlist_trc((lp), (sp), (b), (l), US __FUNCTION__, __LINE__)


ditto.
And finally I set my compiler options to be about the same as yours.

--
Heiko