Re: [exim] "allow_insecure_tainted_data = yes" - was: tainte…

Góra strony
Delete this message
Reply to this message
Autor: Andreas Metzler
Data:  
Dla: exim-users
Temat: Re: [exim] "allow_insecure_tainted_data = yes" - was: tainted data issues
On 2021-04-24 Heiko Schlittermann <hs@???> wrote:
> I believe, the issue is fixed now. I'd be happy, if you **or anybody
> else** can give it a try. To avoid cluttering the official Exim repo,
> this branch is still only in my private but public repositories:

[...]

Good morning Heiko,

thank you. Will upload to Debian/experimental.

Compiler throws two new warnings:

appendfile.c: In function 'appendfile_transport_setup':
appendfile.c:238:1: warning: implicit declaration of function 'open_logs'; did you mean 'openlogs'? [-Wimplicit-function-declaration]
  238 | open_logs("appendfile");
      | ^~~~~~~~~
      | openlogs


I guess

void
-openlogs();
+open_logs(const char *m);

is the proper fix?


log.c: In function 'set_file_path':
log.c:654:45: warning: pointer type mismatch in conditional expression
  654 | uschar *ss = *log_file_path ? log_file_path : LOG_FILE_PATH;
      |                                             ^
In file included from exim.h:486,
                 from log.c:13:
log.c:657:31: warning: passing argument 1 of 'string_nextinlist_trc' from incompatible pointer type [-Wincompatible-pointer-types]
  657 | while ((s = string_nextinlist(&ss, &sep, log_buffer, LOG_BUFFER_SIZE)))
functions.h:560:25: note: in definition of macro 'string_nextinlist'
  560 |  string_nextinlist_trc((lp), (sp), (b), (l), US __FUNCTION__, __LINE__)
      |                         ^~
functions.h:561:53: note: expected 'const uschar **' {aka 'const unsigned char **'} but argument is of type 'uschar **' {aka 'unsigned char **'}
  561 | extern uschar *string_nextinlist_trc(const uschar **listptr, int *separator, uschar *buffer, int buflen,
      |                                      ~~~~~~~~~~~~~~~^~~~~~~


cu Andreas