Re: [pcre-dev] PCRE2 10.35 testing issues on Windows

Top Page
Delete this message
Author: Daniel Richard G.
Date:  
To: Philip Hazel
CC: pcre-dev
Subject: Re: [pcre-dev] PCRE2 10.35 testing issues on Windows
Hi Philip,

On Sun, 2020 Nov 22 10:18-05:00, Philip Hazel wrote:
> Hi Daniel,
>
> I have updated RunTest.bat and committed the patches in r1285. Please
> test. Thanks.


I observed a new error right at the start of the build:

    [  1%] Building C object CMakeFiles/pcre2-8.dir/src/pcre2_auto_possess.c.obj
            C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1427~1.291\bin\Hostx64\x64\cl.exe @C:\Users\ADMINI~1\AppData\Local\Temp\nm27C0.tmp
    pcre2_auto_possess.c
    C:\build\pcre\pcre2-10.36-RC1\build-test\config.h(60): fatal error C1017: invalid integer constant expression
    NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1427~1.291\bin\Hostx64\x64\cl.exe' : return code '0x2'
    Stop.


I looked in config.h around line 60, and saw this:

    /* Provide some support for building in older Windows environments that 
    lack proper integer-type headers. */
    #if defined(WIN32) && !() && !()


It seems to me that the original line in config-cmake.h.in should be
changed from

    #if defined(WIN32) && !(@PCRE2_HAVE_STDINT_H@) && !(@PCRE2_HAVE_INTTYPES_H@)


to

    #if defined(WIN32) && !(@HAVE_STDINT_H@) && !(@HAVE_INTTYPES_H@)


which allows the build to proceed for me.

The test suite still failed, unfortunately:

    Test project C:/build/pcre/pcre2-10.36-RC1/build-test
        Start 1: pcre2_test_bat
    1/2 Test #1: pcre2_test_bat ...................***Failed  Required regular expression not found. Regex=[RunTest\.bat tests successfully completed
    ]  0.07 sec


The error is the same as before. It persists in r1285:    


    C:\build\pcre\pcre2-10.36-RC1\build-test>pcre2_test.bat
    source dir is "C:\build\pcre\pcre2-10.36-RC1"
    pcre2test="$<TARGET_FILE:pcre2test>"
    Error: "$<TARGET_FILE:pcre2test>" not found


I manually fixed the pcre2_test.bat script, and was able to run the test
suite without further issue.


--Daniel


--
Daniel Richard G. || skunk@???
My ASCII-art .sig got a bad case of Times New Roman.