[exim-dev] [Bug 2552] New: smtp_check_spool_space: not check…

https://bugs.exim.org/show_bug.cgi?id=2552

            Bug ID: 2552
           Summary: smtp_check_spool_space: not checking with SIZE
                    parameter correctly
           Product: Exim
           Version: N/A
          Hardware: x86
                OS: All
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Mail Receipt
          Assignee: unallocated@???
          Reporter: erik@???
                CC: exim-dev@???

Created attachment 1288
--> https://bugs.exim.org/attachment.cgi?id=1288&action=edit
patch

In the receive_check_fs function (receive.c) it appears that the msg_size (set
by smtp_check_spool_space in smtp_in.c) isn't used in the spool space
calculation. Note that space appears to be in KB, msg_size in B.

https://github.com/Exim/exim/blob/54a2a2a9983913a91ccef3aac107a159434a4714/src/src/smtp_in.c#L4855-L4870

      if (!receive_check_fs(
       (smtp_check_spool_space && message_size >= 0)?
          message_size + 5000 : 0))
    {

Not used here

https://github.com/Exim/exim/blob/54a2a2a9983913a91ccef3aac107a159434a4714/src/src/receive.c#L258-L298

Attached a suggested patch.

--
You are receiving this mail because:
You are on the CC list for the bug.