[exim-dev] [Bug 2450] exim-4.92.3/src/pdkim/signing.c:415: b…

Top Page

Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2450] exim-4.92.3/src/pdkim/signing.c:415: bad error checking ?
https://bugs.exim.org/show_bug.cgi?id=2450

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???


--- Comment #4 from Git Commit <git@???> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/428cdca73df1791fcba048d0f1093725d8288bd6

commit 428cdca73df1791fcba048d0f1093725d8288bd6
Author:     Jeremy Harris <jgh146exb@???>
AuthorDate: Sun Sep 29 12:49:34 2019 +0100
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Sun Sep 29 12:49:34 2019 +0100


    DKIM: fix errorcheck in signing, lilbgcrypt version.  Bug 2450
---
 src/src/pdkim/signing.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/src/src/pdkim/signing.c b/src/src/pdkim/signing.c
index aff3d90..102e7bf 100644
--- a/src/src/pdkim/signing.c
+++ b/src/src/pdkim/signing.c
@@ -412,8 +412,9 @@ if ( !(s1 = Ustrstr(CS privkey_pem, "-----BEGIN RSA
PRIVATE KEY-----"))

*s2 = '\0';

-if ((der.len = b64decode(s1, &der.data)) < 0)
+if ((rc = b64decode(s1, &der.data) < 0))
return US"Bad PEM-DER b64 decode";
+der.len = rc;

/* untangle asn.1 */

--
You are receiving this mail because:
You are on the CC list for the bug.