[exim-dev] [Bug 2410] integer overflow macros.h

Startseite
Nachricht löschen
Nachricht beantworten
Autor: admin
Datum:  
To: exim-dev
Betreff: [exim-dev] [Bug 2410] integer overflow macros.h
https://bugs.exim.org/show_bug.cgi?id=2410

Johannes Berg <johannes@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johannes@???


--- Comment #2 from Johannes Berg <johannes@???> ---
(In reply to Jeremy Harris from comment #1)
> Thanks for the report. If in the definition of DEBUG_BIT you add a cast of
> the result of BIT() to (int), does that pass the compiler check?


It seems to me that this was already fixed by your

commit bd83c6f989cac6318ee32af3e34d3f5e69b27100
Author: Jeremy Harris <jgh146exb@???>
Date: Thu Apr 25 10:26:46 2019 +0100

    Use unsigned when creating bitmasks in macros



since 1<<31 is undefined behaviour in C on 32-bit (so not surprising that a
compiler might warn about it, if not, UBsan would flag it). But it's not
1U<<31, so should be fine (fits into 32 bits).

(Also reported against 4.92, which doesn't have your fix afaict)

--
You are receiving this mail because:
You are on the CC list for the bug.