[exim-dev] [Bug 2392] exigrep: Option processing is case-ins…

Αρχική Σελίδα
Delete this message
Reply to this message
Συντάκτης: admin
Ημερομηνία:  
Προς: exim-dev
Αντικείμενο: [exim-dev] [Bug 2392] exigrep: Option processing is case-insensitive
https://bugs.exim.org/show_bug.cgi?id=2392

--- Comment #4 from Andreas Metzler <eximusers@???> ---
(In reply to Heiko Schlittermann from comment #3)
> (In reply to Andreas Metzler from comment #2)

[...]
>> Personally I would suggest to change the short form of --related instead,
>> e.g. to "-r". - Imho the current choice (-M) is strange.


> Yes, it is strange, but do we know, if really nobody uses it?


As a data point this broke quite recently (March 2017, released in 4.90
0a27a8228d3ccf0730f54710781abb1185ed26b5) So I think you are right, we do not
know that.

> Maybe add "-r", and keep "-M", but issue a warning before proceeding.
> And somewhen in the future remove "-M".


> Same for other options if they're used case-ignored.


> What do you think?


I think the simple straightforward fix (drop -m) is enough.

-----------
diff --git a/src/src/exigrep.src b/src/src/exigrep.src
index 5db01fe0..57396414 100644
--- a/src/src/exigrep.src
+++ b/src/src/exigrep.src
@@ -223,7 +223,7 @@ GetOptions(
       'pager!'         => \$use_pager,
       'v|invert'       => \$invert,
       'h|help'         => sub { pod2usage(-exit => 0, -verbose => 1) },
-      'm|man'          => sub {
+      'man'            => sub {
         pod2usage(
             -exit      => 0,
             -verbose   => 2,
@@ -356,7 +356,7 @@ Do not use a pager, even if STDOUT is connected to a
terminal.
 Print a short reference help. For more detailed help try L<exigrep(8)>,
 or C<exigrep -m>.


-=item B<-m>|B<--man>
+=item B<--man>

Print this manual page of B<exigrep>.
-----------

--
You are receiving this mail because:
You are on the CC list for the bug.