Re: [exim-dev] Missing Colon on I= for outbound mail?

Top Page
Delete this message
Reply to this message
Author: Heiko Schlittermann
Date:  
To: exim-dev
Subject: Re: [exim-dev] Missing Colon on I= for outbound mail?
Larry,
do you agree with this commit? Especially with the commit message, as it mentions
your name and address.

    Author: Heiko Schlittermann (HS12-RIPE) <hs@???>
    Date:   Fri Mar 8 18:29:20 2019 +0100


        Add missing colon when logging outgoing I=


        Credits to Larry Rosenman <ler@???> for reporting this.


    diff --git a/src/src/deliver.c b/src/src/deliver.c
    index 506470070..071187942 100644
    --- a/src/src/deliver.c
    +++ b/src/src/deliver.c
    @@ -758,7 +758,7 @@ if (LOGGING(incoming_interface) && LOGGING(outgoing_interface)
    {
    g = string_fmt_append(g, " I=[%s]", sending_ip_address);
    if (LOGGING(outgoing_port))
    -    g = string_fmt_append(g, "%d", sending_port);
    +    g = string_fmt_append(g, ":%d", sending_port);
    }
    return g;
    }


    Best regards from Dresden/Germany
    Viele Grüße aus Dresden
    Heiko Schlittermann
--
 SCHLITTERMANN.de ---------------------------- internet & unix support -
 Heiko Schlittermann, Dipl.-Ing. (TU) - {fon,fax}: +49.351.802998{1,3} -
 gnupg encrypted messages are welcome --------------- key ID: F69376CE -
 ! key id 7CBF764A and 972EAC9F are revoked since 2015-01 ------------ -