[exim-dev] [Bug 2366] New: dkim_verify_signers not honoured …

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2366] New: dkim_verify_signers not honoured for incoming SMTP since 4.91
https://bugs.exim.org/show_bug.cgi?id=2366

            Bug ID: 2366
           Summary: dkim_verify_signers not honoured for incoming SMTP
                    since 4.91
           Product: Exim
           Version: 4.91
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: DKIM
          Assignee: tom@???
          Reporter: alex.exim@???
                CC: exim-dev@???


Created attachment 1171
--> https://bugs.exim.org/attachment.cgi?id=1171&action=edit
Proposed patch (needs -p1)

The dkim_smtp_dkim ACL is now only called for the signatures that are present
in the message, ignoring any additional requests for verification in
dkim_verify_signers.

The dkim_verify_signers configuration option can still be set in the
configuration file, and can be seen to take effect with `exim -bP
dkim_verify_signers`, but it is reset to the default (i.e. just $dkim_signers)
at the start of an SMTP session. See its assignment in smtp_reset() in
src/smtp_in.c.

I can't see it being modified anywhere else so I can't see any justification
for resetting it at all, let alone to the default rather than to the configured
value. Indeed, simply removing that assignment has got me working again and I
haven't noticed any side-effects so far... What have I missed?!

Patch attached, for what it's worth.

--
You are receiving this mail because:
You are on the CC list for the bug.