[pcre-dev] [Bug 2334] "make test" reports test failures when…

Top Pagina
Delete this message
Auteur: admin
Datum:  
Aan: pcre-dev
Onderwerp: [pcre-dev] [Bug 2334] "make test" reports test failures when running on macOS (x86_64)
https://bugs.exim.org/show_bug.cgi?id=2334

--- Comment #24 from Rich Siegel <siegel@???> ---
(In reply to Zoltan Herczeg from comment #21)
> I got a simplified patch privately and landed it. I haven't seen the
> discussion here.


Please note, that per my comment #19, using "__APPLE__" as the conditional test
is incorrect. You must use "TARGET_OS_MAC" for the reasons I described there.

In turn, TARGET_OS_MAC needs to be set by including (conditionally)
<TargetConditionals.h>.

> I even noticed the code compiles on Linux as well which is a surprise.


Yes, Linux supports uname(3).

I have provided a patch against r1053 which implements my comment above.

--
You are receiving this mail because:
You are on the CC list for the bug.