[pcre-dev] [Bug 2334] "make test" reports test failures when…

Top Page
Delete this message
Author: admin
Date:  
To: pcre-dev
Subject: [pcre-dev] [Bug 2334] "make test" reports test failures when running on macOS (x86_64)
https://bugs.exim.org/show_bug.cgi?id=2334

--- Comment #17 from Rich Siegel <siegel@???> ---
Created attachment 1150
--> https://bugs.exim.org/attachment.cgi?id=1150&action=edit
patch for src/sljit/sljitExecAllocator.c to fix TARGET_OS_MAC defining

Thank you! Unfortunately this does not pass the tests; some includes were left
out, including <TargetConditions.h> which is required to correctly configure
TARGET_OS_MAC, so the changes were not compiled in and MAP_JIT was always used,
which fails on OS versions before 10.14.

Adding the following lines at line 97 in r1046 of
src/src/sljit/sljitExecAllocator.c will resolve this:

#ifdef __APPLE_CC__
#include <TargetConditionals.h>    //    autoconfigures TARGET_OS_MAC


#if TARGET_OS_MAC && defined(MAP_JIT)

#include <sys/sysctl.h>
#include <sys/utsname.h>
#include <stdio.h>
#include <dispatch/dispatch.h>

#endif
#endif

I've attached a patch file as well.

--
You are receiving this mail because:
You are on the CC list for the bug.