Συντάκτης: Phil Pennock Ημερομηνία: Προς: Exim-dev Αντικείμενο: Re: [exim-dev] buildfarm client proposal: tests configure support
On 2018-09-16 at 12:49 +0100, Jeremy Harris via Exim-dev wrote: > The code addition looks reasonable on the surface. Go head and
> push it to master.
I'm going to let Heiko make his suggested improvements.
> I'm not going to spend time trying to duplicate your work...
> once you're up and running, a potted recipe would be
> useful for posterity. I can't guess how you managed
> to do a main exim build without those headers... presumably
> you're not limiting yourself to a no-ssl exim (if so,
> perhaps we need a no-ssl testsuite build option).
PKG_CONFIG_PATH defined in Local/Makefile instead.
On 2018-09-17 at 10:17 +0200, Heiko Schlittermann via Exim-dev wrote: > This should have the same result, but is more reliable in restoring the
> old %ENV when leaving the scope.
If there had been an exception option, yes. Frankly, the problem here
is that I haven't written new Perl in 10+ years so have forgotten many
of the idioms. I loathe letting things inside other languages go near
shell, but wanted to minimise the scope of changes, so went for escaping
instead.
Your proposals all look sane to me. Please go ahead and fix.
I've also just sorted out access to the Mac Mini testing box for you
Heiko; I'll email you details off-list.
