[exim-dev] [Bug 2316] Missing Error Check in function X509_…

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2316] Missing Error Check in function X509_NAME_oneline()
https://bugs.exim.org/show_bug.cgi?id=2316

--- Comment #2 from Chi Li <chi-li18@???> ---
(In reply to Jeremy Harris from comment #1)
> The docs at
> https://www.openssl.org/docs/man1.0.2/crypto/X509_NAME_oneline.html
> do not say that NULL can be returned. Nor do the 1.1.0 versions.


Sorry, It was my fault to forget to check the docs about the version 1.0.2.
However, in the ref
https://www.openssl.org/docs/manmaster/man3/X509_NAME_oneline.html which is the
latest version docs says NULL on error.

Also,the 1.0.2 version is already corrected referring to the latest standards.

ref:
https://github.com/openssl/openssl/blob/OpenSSL_1_0_2-stable/crypto/x509v3/v3_alt.c

152:        if (X509_NAME_oneline(gen->d.dirn, oline, 256) == NULL
153:                || !X509V3_add_value("DirName", oline, &ret))
154:           return NULL;



The 1.1.0 version is corrected too.

ref:
https://github.com/openssl/openssl/blob/OpenSSL_1_1_0-stable/crypto/x509v3/v3_alt.c

103:        if (X509_NAME_oneline(gen->d.dirn, oline, 256) == NULL
104:                || !X509V3_add_value("DirName", oline, &ret))
105:           return NULL;


--
You are receiving this mail because:
You are on the CC list for the bug.