Re: [pcre-dev] memmove() vs. bcopy()

On Fri, 2018 Aug 10 17:36+0100, ph10@??? wrote:
> I have done this and tested it (!). It turned out to be not quite as
> trivial as modifying the existing function, because that was defined
> as a static function in pcre2_internal.h, included by all PCRE2
> modules. Only a few actually use memmove(), and I was getting lots of
> compiler warnings about an unused function from all the others. The
> implementation seems to go back to 2000, when I suspect I wasn't using
> so many compiler warnings (or so many modules), but there have been
> various fixes since then (see PCRE1 ChangeLog).

This is usually addressed with __attribute__((unused)) for GCC/Clang.

> Now the emulation is in a private library function, and both pcre2test
> and pcre2grep have their own static versions. It all seems to work.
> I've committed the patch.

Three copies of the same function... I don't know...

In any event, thanks for looking at this, and keeping the compatibility.


--Daniel


P.S.: Please Cc: me in any reply, as I am not subscribed to this list.


--
Daniel Richard G. || skunk@???
My ASCII-art .sig got a bad case of Times New Roman.