[exim-dev] [Bug 2295] Invalid DKIM signatures (due to header…

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2295] Invalid DKIM signatures (due to header hash miscomputed)
https://bugs.exim.org/show_bug.cgi?id=2295

--- Comment #1 from Guillaume Outters <guillaume-exim@???> ---
Humph, looking at https://bugs.exim.org/show_bug.cgi?id=2278#c4 makes me think
that ea18931 only did group:
pdkim_headcat(&col,hdr,";","b=","");
pdkim_headcat(&col,hdr,NULL,";","");
into:
pdkim_headcat(&col,hdr,";","b=;","");

But then, why would it correct an EOL introduced between "b=" and ";" (as
intended)?
The only case where I see it could occur would be when the 78-character split
occurs just between the "b=" and the ";", but then pdkim_headcat()'s job is
precisely to split, even when it is passed a grouped "b=;", so we would have
the parasiting EOL anyway.

I think the whole "ending ;" thing should go away: when final, as I propose in
the bug description, but when !final too, as Jasen Betts commented in
05b7d6de8bb1c92587cc639eeb1be485a1b79c25 with the "add trailing semicolon: I'm
not sure if this is actually needed".

--
You are receiving this mail because:
You are on the CC list for the bug.