Re: [pcre-dev] [PATCH] PCRE2 on Windows

Top Page
Delete this message
Author: ph10
Date:  
To: Daniel Richard G.
CC: pcre-dev
Subject: Re: [pcre-dev] [PATCH] PCRE2 on Windows
On Mon, 7 May 2018, Daniel Richard G. wrote:

> * Currently, the generic pcre2.h header (under src/) in the source tree
> is used instead of the generated pcre2.h in the build tree. This is
> due to the use of #include"pcre2.h" instead of #include<pcre2.h>.
> Would it be all right to change all instances of the former to the
> latter in the PCRE2 source?


I have patched both configure.ac and CMakeLists.txt so that they delete
pcre2.h and config.h from the source tree before doing their thing. This
should solve this issue if you build in a non-source directory after
downloading from the repo or indeed if you build in a different
directory after previously configuring in the source directory. (This
has caught me in the past when testing.)

> * I am seeing some errors from the French-locale test on an older
> Solaris system, which has fr_CA. I'm not quite sure how to diagnose
> the problem. Would you be able to make heads or tails of it if I
> posted the output?


You can always try me...

Philip

--
Philip Hazel