[exim-dev] [Bug 2278] Invalid outgoing DKIM header signature

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2278] Invalid outgoing DKIM header signature
https://bugs.exim.org/show_bug.cgi?id=2278

--- Comment #4 from Simon Arlott <bugzilla.exim.simon@???> ---
This can be fixed for 4.86 using ea18931d9b1e9b73b699a2f3eb661d70b7f52fab:

Index: exim4-4.86.2/src/pdkim/pdkim.c
===================================================================
--- exim4-4.86.2.orig/src/pdkim/pdkim.c
+++ exim4-4.86.2/src/pdkim/pdkim.c
@@ -1397,14 +1397,13 @@ char *pdkim_create_header(pdkim_signatur
       base64_b = pdkim_encode_base64(sig->sigdata, sig->sigdata_len);
       if (base64_b == NULL) goto BAIL;
       if(!pdkim_headcat(&col,hdr,";","b=",base64_b)) goto BAIL;
+      /* add trailing semicolon: I'm not sure if this is actually needed */
+      if(!pdkim_headcat(&col,hdr,NULL,";","")) goto BAIL;
     }
     else {
-      if(!pdkim_headcat(&col,hdr,";","b=","")) goto BAIL;
+      if(!pdkim_headcat(&col,hdr,";","b=;","")) goto BAIL;
     }


-    /* add trailing semicolon: I'm not sure if this is actually needed */
-    if(!pdkim_headcat(&col,hdr,NULL,";","")) goto BAIL;
-
     goto DONE;
   }


--
You are receiving this mail because:
You are on the CC list for the bug.