[exim-dev] [Bug 2262] New: exim-4.91/src/arc.c:1549: bad if …

https://bugs.exim.org/show_bug.cgi?id=2262

            Bug ID: 2262
           Summary: exim-4.91/src/arc.c:1549: bad if test ?
           Product: Exim
           Version: N/A
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: bug
          Priority: medium
         Component: General execution
          Assignee: nigel@???
          Reporter: dcb314@???
                CC: exim-dev@???

[exim-4.91/src/arc.c:1549]: (style) Boolean result is used in bitwise
operation. Clarify expression with parentheses.

Source code is

if ( !*identity | !*selector
|| !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey)
{

Maybe better code

if ( !*identity || !*selector
|| !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey)
{

--
You are receiving this mail because:
You are on the CC list for the bug.