Re: [exim-dev] Exim 4.91 RC1

Top Page
Delete this message
Reply to this message
Author: Jeremy Harris
Date:  
To: exim-dev@exim.org
Subject: Re: [exim-dev] Exim 4.91 RC1
On 17/03/18 01:52, Phil Pennock wrote:
> Building for `next-exim` on the exim.org box, the port-26 listener:
>
>  * `EXPERIMENTAL_ARC` is not given with `=yes` in `src/EDITME`, which is
>    inconsistent at least


Fixed.

> * First build attempt failed:


> malware.c:2150:6: error: ‘ava_re_clean’ undeclared (first use in this function)
> if (!ava_re_clean)


Fixed

> malware.c:2156:6: error: ‘fprot6d_re_error’ undeclared (first use in this function)
> if (!fprot6d_re_error)


Fixed, though my poor eyes cannot actually see the difference that
gitk assures me is there!


>  * While the `DISABLE_DNSSEC=yes` option has the comment `Enabling
>    SUPPORT_DANE unconditionally overrides this setting.`, other options
>    are "you must have this other thing turned on or build will fail",
>    which might be worth reconsidering.


True. Changed to match the general pattern.

>  Enabling DMARC without enabling
>    SPF led to a build failure almost at the very end.


Compile-time or link-time failure? Do you think we need
a specific check early in the build?

--
Cheers,
Jeremy