[pcre-dev] [Bug 2247] build failure on m68k

Top Page
Delete this message
Author: admin
Date:  
To: pcre-dev
Subject: [pcre-dev] [Bug 2247] build failure on m68k
https://bugs.exim.org/show_bug.cgi?id=2247

--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@???> ---
Thanks, however I got some review on the Buildroot mailing list that made me
realize that my patch is probably not perfect: it changes the layout of the
structure when compiling the 32-bit variant.

In the 32-bit variant, the unused array should be *before* the occu[1] array.
Indeed, on most architectures, the occu[1] will be aligned on 32-bit boundary,
leaving 16 bits empty before the previous 8-bit field. Except on m68k, where
occu[1] will be right after the 8-bit field. To fix this, it is better to but
the padding (unused[2]) before the occu[1] array. This ensures that the
structure layout remains the same.

--
You are receiving this mail because:
You are on the CC list for the bug.