Re: [pcre-dev] pcre2test.c: Double assignment of "capcount" …

Page principale
Supprimer ce message
Auteur: ph10
Date:  
À: Ralf Junker
CC: pcre-dev@exim.org
Sujet: Re: [pcre-dev] pcre2test.c: Double assignment of "capcount" variable intentional?
On Wed, 12 Apr 2017, Ralf Junker wrote:

> As of current SVN 740, in this code in pcre2test.c starting at line
> 6722, the 1st assignment of capcount is always overwritten by the 2nd
> one:
>
> if (FLD(compiled_code, executable_jit) == NULL || 
>           (dat_datctl.options & PCRE2_NO_JIT) != 0)
>         {   
>         capcount = check_match_limit(pp, arg_ulen, PCRE2_ERROR_HEAPLIMIT, 
>           "heap");
>         }
>       capcount = check_match_limit(pp, arg_ulen, PCRE2_ERROR_MATCHLIMIT, 
>         "match");
>       }   
>     else capcount = 0;

>
> If this is intentional, please disregard this notice. Otherwise, there might be an else missing.


It is intentional, but I agree that it is confusing. Thanks for
noticing. I have changed the first "capcount =" to (void) and also added
to the preceding comment.

Philip

--
Philip Hazel