[exim-dev] [Bug 2014] DKIM test fails at signed signatures (…

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2014] DKIM test fails at signed signatures (multi-DKIM)
https://bugs.exim.org/show_bug.cgi?id=2014

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???


--- Comment #1 from Git Commit <git@???> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/eea190173538a3e71a87f174baa190cb22e0e8fb

commit eea190173538a3e71a87f174baa190cb22e0e8fb
Author:     Jeremy Harris <jgh146exb@???>
AuthorDate: Sun Jan 22 17:35:08 2017 +0000
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Sun Jan 22 17:37:05 2017 +0000


    DKIM: permit verify of sig blocks that sign other sig blocks.  Bug 2014
---
 doc/doc-txt/ChangeLog | 4 ++++
 src/src/pdkim/pdkim.c | 5 ++---
 2 files changed, 6 insertions(+), 3 deletions(-)


diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 156a89f..a680593 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -45,6 +45,10 @@ JH/08 Bug 2016: Fix DKIM verification vs. CHUNKING.  Any
BDAT commands after
       processing; with most chunk sizes in use this resulted in an incorrect
       body hash calculated value.


+JH/09 Bug 2014: permit inclusion of a DKIM-Signature header in a received
+      DKIM signature block, for verification.  Although advised against by
+      standards it is specifically not ruled illegal.
+


 Exim version 4.88
 -----------------
diff --git a/src/src/pdkim/pdkim.c b/src/src/pdkim/pdkim.c
index 4309675..a77dd57 100644
--- a/src/src/pdkim/pdkim.c
+++ b/src/src/pdkim/pdkim.c
@@ -991,9 +991,8 @@ else
       "PDKIM
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<\n");
     }


-  /* every other header is stored for signature verification */
-  else
-    ctx->headers = pdkim_prepend_stringlist(ctx->headers, ctx->cur_header);
+  /* all headers are stored for signature verification */
+  ctx->headers = pdkim_prepend_stringlist(ctx->headers, ctx->cur_header);
   }


BAIL:

--
You are receiving this mail because:
You are on the CC list for the bug.