Andreas Metzler <eximusers@???> (Do 19 Jan 2017 15:44:17 CET):
> Hello,
>
> I am considering to temporarily disable BDAT in Debian's exim packages.
>
> Afaict BDAT in exim is still stabilizing, multiple issues have shown up
> since 4.88 and some are still unfixed.
>
> OTOH we (Debian) do not have time to wait for BDAT to get ready. Debian
> is currently preparing for a new stable release. On February 5 the "Full
> Freeze" will come into effect, i.e. uploads targeted for the release
> will require manual approval by the release team. (With the ten day
> waiting period for automatic appproval, the upload deadline is about
> January 26.
>
> I would apply the attached patch.
> Any thoughts, strong opinions against?
Good idea. We survived years w/o chunking :)
> diff --git a/src/src/globals.c b/src/src/globals.c
> index 90e46dff..8f26487a 100644
> --- a/src/src/globals.c
> +++ b/src/src/globals.c
> @@ -494,7 +494,7 @@ BOOL check_rfc2047_length = TRUE;
> int check_spool_inodes = 100;
> int check_spool_space = 10*1024; /* 10K Kbyte == 10MB */
>
> -uschar *chunking_advertise_hosts = US"*";
> +uschar *chunking_advertise_hosts = NULL;
> unsigned chunking_datasize = 0;
> unsigned chunking_data_left = 0;
> BOOL chunking_offered = FALSE;
The above patch is Ok, IMHO.
> diff --git a/src/src/transports/smtp.c b/src/src/transports/smtp.c
> index 87082717..314d74f1 100644
> --- a/src/src/transports/smtp.c
> +++ b/src/src/transports/smtp.c
> @@ -206,7 +206,7 @@ smtp_transport_options_block smtp_transport_option_defaults = {
> NULL, /* serialize_hosts */
> NULL, /* hosts_try_auth */
> NULL, /* hosts_require_auth */
> - US"*", /* hosts_try_chunking */
> + NULL, /* hosts_try_chunking */
> #ifdef EXPERIMENTAL_DANE
> NULL, /* hosts_try_dane */
> NULL, /* hosts_require_dane */
But this patch?? As far as I know, the issues with chunking are
*inbound*, not outbound, so, the disabling chunking for outgoing
connections isn't strictly necessary.
But I'd add update the spec, just in case somebody reads it:
--- a/doc/doc-docbook/spec.xfpt
+++ b/doc/doc-docbook/spec.xfpt
@@ -14437,12 +14437,14 @@ may wish to deliberately disable them.
.wen
.new
-.option chunking_advertise_hosts main "host list&!!" *
+.option chunking_advertise_hosts main "host list&!!" unset
.cindex CHUNKING advertisement
.cindex "RFC 3030" "CHUNKING"
The CHUNKING extension (RFC3030) will be advertised in the EHLO message to
these hosts.
Hosts may use the BDAT command as an alternate to DATA.
+(Defaulting this option to "unset" is Debian specific. Nativ Exims
+default to "*".)
.wen
.option daemon_smtp_ports main string &`smtp`&
Best regards from Dresden/Germany
Viele Grüße aus Dresden
Heiko Schlittermann
--
SCHLITTERMANN.de ---------------------------- internet & unix support -
Heiko Schlittermann, Dipl.-Ing. (TU) - {fon,fax}: +49.351.802998{1,3} -
gnupg encrypted messages are welcome --------------- key ID: F69376CE -
! key id 7CBF764A and 972EAC9F are revoked since 2015-01 ------------ -
