[exim-dev] [Bug 1838] Check the return value of every calls …

Top Pagina
Delete this message
Reply to this message
Auteur: admin
Datum:  
Aan: exim-dev
Onderwerp: [exim-dev] [Bug 1838] Check the return value of every calls to malloc()
https://bugs.exim.org/show_bug.cgi?id=1838

--- Comment #2 from ytrezq@??? ---
(In reply to Jeremy Harris from comment #1)
> We don't deal in pulls. Please attach suggested patches to bugs.
> Also, rather than changing code around malloc calls it would be preferred to
> use the project standard memory management facilities - even though
> converting
> code to use them is a larger job.


yes, but I have some concerns about using store_malloc everywhere.

In many places, the value of malloc is checked to allow function failing
without killing the exim daemon.

for example in tls_gnu.

  m.data = malloc(m.size);
  if (m.data == NULL)
    {
    fclose(fp);
    return tls_error(US"malloc failed", strerror(errno), NULL);
    }


which simply abort the dh exchange instead of killing exim.

But I understand and will post patches here. Just wait 20 min.

--
You are receiving this mail because:
You are on the CC list for the bug.